Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps/yara: force rebuild if config changed, fix #760 #763

Merged
merged 1 commit into from
May 11, 2020
Merged

Conversation

PeterMatula
Copy link
Collaborator

No description provided.

@PeterMatula
Copy link
Collaborator Author

lets run tc tests

@PeterMatula PeterMatula requested a review from s3rvac May 4, 2020 20:43
@PeterMatula
Copy link
Collaborator Author

PeterMatula commented May 4, 2020

@s3rvac can you have a look? It works for me, but this kind of things are tricky, so I would feel better if someone else tried it and looked at the solution.

Ad solution: it is complicated by:

  • external project configuration is different for MSVC than for other environments
  • YARA is not built using CMake, but in source using make/MSVC solution
  • simply triggering rebuild without cleaning does not work. CMake will not download the package again [and clean everything] because it did not change, and in-source build will not properly rebuild if it was already built.

@s3rvac
Copy link
Member

s3rvac commented May 5, 2020

Sure, I will take a look.

Copy link
Member

@s3rvac s3rvac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me on Linux and I do not see anything wrong with the code. So, approving 👍 Thank you for looking into that. I think it will prevent possible headaches with changing YARA parameters in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants