Improve the detection of CExe packer by modifying the YARA rule. #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new YARA rule is more inclusive and correct one bug by changing the variable byte in the call byte.
|
Let's run TC tests. |
s3rvac
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new YARA rule is more inclusive and correct one bug by changing the
variable byte in the call byte.
The change is twofold, the call
had its most significant byte set to a wildcard, while in reality, it should have been the least significant byte instead.
Finally, there is a version that has the final jump of the detecting code jump slightly closer.
Since it's the last byte, it's worth simply removing it.
The change is minute, not affecting current detections, therefore I have not added any tests.
If you think tests should be added, please let me know.