Do not fail completely when retdec-archive-decompiler is not available #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metthal
force-pushed
the
retdec-fileinfo-archives
branch
from
2884d09
to
3f6ba3a
Compare
metthal
changed the title
metthal
changed the title
metthal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If only
retdec-fileinfoandretdec-unpackerare built and installed, thenretdec-archive-decompileris not installed. However in order to importretdec-fileinfo.py, it needsretdec-archive-decompiler.py. We'd like to have retdec fileinfo config handled better (through some JSONs) but this should at least solve it temporarily until better solution is made.