Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of .NET analysis differences #997

Merged
merged 15 commits into from
Aug 30, 2021
Merged

Conversation

HoundThe
Copy link
Member

@HoundThe HoundThe commented Aug 8, 2021

This PR is fixing several .NET parsing differences and bugs:

  • Type namespace creation for Nested types that also have a namespace
  • Parameter reconstruction from the signature only when Param information is missing
  • Fixing incorrect .NET visibility output
  • FileInfo not detecting any class information for some files
    • Understand ExtraData flag in Metadata Stream header
    • Use always the first instance of a stream type (sometimes samples have multiple of streams, but the first one is the valid one)
  • Accept empty strings in StringHeap
  • Rework BlobStream as there can be a valid blob stream at any offset
  • Add bound checking when recreating arrays
  • Add more checks to validate if the file is actually a .NET file

@HoundThe HoundThe marked this pull request as ready for review August 9, 2021 16:47
@metthal
Copy link
Member

metthal commented Aug 12, 2021

Is this ready for merge?

@HoundThe
Copy link
Member Author

I'll add some new tests and correct the existing ones before merging

@PeterMatula PeterMatula self-requested a review August 24, 2021 07:28
@PeterMatula
Copy link
Collaborator

lets run TC tests

Copy link
Collaborator

@PeterMatula PeterMatula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, it looks ok. Only a few questions.
Maybe @metthal would like to have a look as well.

@PeterMatula PeterMatula merged commit 704d1db into avast:master Aug 30, 2021
PeterMatula added a commit that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants