Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using Python3 module to detect a python #999

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

catap
Copy link
Contributor

@catap catap commented Aug 13, 2021

PythonInterp is old and deprecated module which may gave up on a system with multiple python installation like 2.7 and 3.x where /usr/bin/python is 2.7.

`PythonInterp` is old and deprecated module which may gave up on a system with multiple python installation like 2.7 and 3.x where `/usr/bin/python` is 2.7.
@catap
Copy link
Contributor Author

catap commented Aug 13, 2021

Similar hack is required for macOS 10.15 with macports: macports/macports-ports#11855

@xkubov
Copy link
Contributor

xkubov commented Aug 16, 2021

Lets run TC tests.

@PeterMatula
Copy link
Collaborator

Thanks @catap, looks like a good change. It also looks that all of our CI configs don't like it, but we are investigating and hopefully will make them behave.

@catap
Copy link
Contributor Author

catap commented Aug 18, 2021

@PeterMatula it one of patches that is required to macport's.

@xkubov
Copy link
Contributor

xkubov commented Aug 25, 2021

So Linux and windows build should be good now - after rebasing onto current master all tests should pass. We must wait, however, for the update of the mac TeamCity agent before merging. The change requires a newer CMake version than we currently have installed and we have some problems with the mac agent at the moment. I will merge this after it is sorted out.

@xkubov
Copy link
Contributor

xkubov commented Sep 13, 2021

I have checked the TC builds and all of them are passing now (excluding Doxygen build). Therefore, I am merging this, thanks @catap.

@xkubov xkubov merged commit ebfd10d into avast:master Sep 13, 2021
@catap catap deleted the patch-1 branch September 13, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants