Introduce UntilSucceeded option to improve readability #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natenho
changed the title
|
The unsuccessful check has nothing to do with the PR |
|
Hi @natenho thanks for you PR |
kodiakhq bot
pushed a commit
to cloudquery/plugin-pb-go
that referenced
this pull request
Apr 30, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/avast/retry-go/v4](https://github.com/avast/retry-go) | require | minor | `v4.5.1` -> `v4.6.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>avast/retry-go (github.com/avast/retry-go/v4)</summary> ### [`v4.6.0`](https://github.com/avast/retry-go/releases/tag/v4.6.0) [Compare Source](https://github.com/avast/retry-go/compare/4.5.1...4.6.0) #### What's Changed - Introduce UntilSucceeded option to improve readability by [@​natenho](https://github.com/natenho) in [avast/retry-go#116 - Fix the inconsistency in the number of times passed in onRetry by [@​FarmerChillax](https://github.com/FarmerChillax) in [avast/retry-go#114 - Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 by [@​dependabot](https://github.com/dependabot) in [avast/retry-go#112 #### New Contributors - [@​natenho](https://github.com/natenho) made their first contribution in [avast/retry-go#116 - [@​FarmerChillax](https://github.com/FarmerChillax) made their first contribution in [avast/retry-go#114 **Full Changelog**: avast/retry-go@v4.5.1...v4.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjkuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMyOS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, IMHO, the
Attemps(0)approach leads to surprises as it has no clear meaning.So with this PR, instead of
You should also be able to write
UntilSucceeded()And the code becomes much more clear to read and understand.
Attemps(0) will continue to work, but I think it should be removed in another major version, in favor of a more intuitive API.
Also, I've made small changes in docs.