Add an ability to mark error as unrecoverable #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 96.77% 97.14% +0.36%
==========================================
Files 2 2
Lines 62 70 +8
==========================================
+ Hits 60 68 +8
Misses 2 2
Continue to review full report at Codecov.
|
JaSei
approved these changes
Jul 13, 2019
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 96.77% 97.14% +0.36%
==========================================
Files 2 2
Lines 62 70 +8
==========================================
+ Hits 60 68 +8
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a possibility to short-circuit the execution if an error is unrecoverable using
RetryIffunction. However, I find it ugly to match error strings and inconvenient to create separate types for unrecoverable errors all the time. So I thought about a built-in way to handle simple unrecoverable errors.