Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(testkit): initial implementation #85

Merged
merged 1 commit into from
Apr 9, 2020
Merged

feat(testkit): initial implementation #85

merged 1 commit into from
Apr 9, 2020

Conversation

hanny24
Copy link
Contributor

@hanny24 hanny24 commented Apr 8, 2020

No description provided.

jakubjanecek
jakubjanecek approved these changes Apr 8, 2020
View reviewed changes
api/src/test/scala/slog4s/MockClock.scala

import scala.concurrent.duration.Duration

class MockClock[F[_]](val real: Ref[F, Long], val mono: Ref[F, Long])(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this class be part of the testkit?

Copy link
Contributor Author

@hanny24 hanny24 Apr 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used only for test of the testkit. I don't want to expose more public API than needed.

@hanny24 hanny24 added the feature label Apr 9, 2020
@hanny24 hanny24 merged commit e5b22df into master Apr 9, 2020
@hanny24 hanny24 deleted the testkit branch April 9, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubjanecek jakubjanecek jakubjanecek approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanny24 @jakubjanecek