Skip to content

Commit

Permalink
Revert "CI/Makefile: disable uninlined_format_args clippy lint"
Browse files Browse the repository at this point in the history
This reverts commit 4964b44.

The main reason that uninlined_format_args lint was disabled in Rust 
Driver's CI/Makefile was that inlined variables in format strings had 
spotty support in rust-analyzer: rust-analyzer did not support renaming
variables inside format strings.

Fortunately, rust-analyzer recently gained support for renaming 
variables in format strings: rust-lang/rust-analyzer#16027, therefore
4964b44 can now be reverted. 

Moreover, Rust 1.67.1 downgraded uninlined_format_args to pedantic, 
meaning that it's disabled by default and we don't have to disable it
manually. If it's ever promoted back to an enforced rule by default,
we'll be ready to deal with it again (with a proper rust-analyzer 
support) - not addressing it now to avoid merge conflicts with other
bigger planned PRs.

Closes scylladb#643
  • Loading branch information
avelanarius committed Mar 4, 2024
1 parent 87908f3 commit 55c8a45
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Format check
run: cargo fmt --verbose --all -- --check
- name: Clippy check
run: cargo clippy --verbose --all-targets -- -Aclippy::uninlined_format_args
run: cargo clippy --verbose --all-targets
- name: Cargo check without features
run: cargo check --all-targets --manifest-path "scylla/Cargo.toml" --features ""
- name: Cargo check with all serialization features
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ check-without-features:

.PHONY: clippy
clippy:
RUSTFLAGS=-Dwarnings cargo clippy --all-targets -- -Aclippy::uninlined_format_args
RUSTFLAGS=-Dwarnings cargo clippy --all-targets

.PHONY: test
test: up
Expand Down

0 comments on commit 55c8a45

Please sign in to comment.