Add revive as suggestion #2757
Closed
Add revive as suggestion #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because tl;dr (the devs of) golang/lint suck: golang/lint#186 (comment) Yes, I've rewritten the description of the revive project to one sentence. Also "fast" & "beautiful" is relative to the moment they're stated. They could be invalid in the future. Any suggestions to get this PR though are very welcome
|
Thank you for contributing with awesome-go, we will revise your contribution as soon as possible. Automation body content check:
|
ceriath
requested changes
Oct 4, 2019
There was a problem hiding this comment.
Please goftmt the library https://goreportcard.com/report/github.com/mgechev/revive#gofmt
fix https://goreportcard.com/report/github.com/mgechev/revive#golint
and fix https://goreportcard.com/report/github.com/mgechev/revive#ineffassign
otherwise LGTM
|
Unfortunately I'm only an user of the tool who found it awesome. ...And not the owner of the repository. What should I do now? /0\ |
|
You could still do the changes and open a pull request on their project, if you want to help to improve "revive" |
|
Closing this due to inactivity. Please feel free to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because tl;dr (the devs of) golang/lint suck: golang/lint#186 (comment)
Yes, I've rewritten the description of the revive project to one sentence. Also "fast" & "beautiful" is relative to the
momentsituation they're stated. They could be invalid in the future.Any suggestions to get this PR though are very welcome~
Please check if what you want to add to
awesome-golist meets quality standards before sending pull request. Thanks!Please provide package links to:
Very good coverage
Note: that new categories can be added only when there are 3 packages or more.
Well, since this PR makes there are 3 linters in this list, it IS an idea to do so....
Make sure that you've checked the boxes below before you submit PR:
Thanks for your PR, you're awesome! 👍