-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gut/yos in Files section #2964
Conversation
Thank you for contributing with awesome-go, we will revise your contribution as soon as possible. Automation body content check:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the golint issues and fix the failure of GitHub action build on Windows.
@panjf2000 Thanks for your review! Build break was already fixed. golint issue for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golint issue for
yrand.QuitShuffle
is by design, since it acts likefilepath.SkipDir
, and not a real error.
Then you could add a //nolint: xxx
comment upon it to eliminate that warning.
Thanks! I just tried It seems that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Please check if what you want to add to
awesome-go
list meets quality standards before sending pull request. Thanks!Please provide package links to:
Very good coverage
Note: that new categories can be added only when there are 3 packages or more.
Make sure that you've checked the boxes below before you submit PR:
Thanks for your PR, you're awesome! 👍