Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gut/yos in Files section #2964

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Add gut/yos in Files section #2964

merged 1 commit into from
Feb 21, 2020

Conversation

an63
Copy link
Contributor

@an63 an63 commented Feb 16, 2020

Please check if what you want to add to awesome-go list meets quality standards before sending pull request. Thanks!

Please provide package links to:

Very good coverage

Note: that new categories can be added only when there are 3 packages or more.

Make sure that you've checked the boxes below before you submit PR:

  • I have added my package in alphabetical order.
  • I have an appropriate description with correct grammar.
  • I know that this package was not listed before.
  • I have added godoc link to the repo and to my pull request.
  • I have added coverage service link to the repo and to my pull request.
  • I have added goreportcard link to the repo and to my pull request.
  • I have read Contribution guidelines, maintainers note and Quality standard.

Thanks for your PR, you're awesome! 👍

@avelino
Copy link
Owner

avelino commented Feb 16, 2020

Thank you for contributing with awesome-go, we will revise your contribution as soon as possible.

Automation body content check:

  • godoc.org: True
  • goreportcard.com: True
  • coverage: True

Copy link
Collaborator

@panjf2000 panjf2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the golint issues and fix the failure of GitHub action build on Windows.

@an63
Copy link
Contributor Author

an63 commented Feb 19, 2020

@panjf2000 Thanks for your review! Build break was already fixed. golint issue for yrand.QuitShuffle is by design, since it acts like filepath.SkipDir, and not a real error.

@an63 an63 requested a review from panjf2000 February 20, 2020 02:09
Copy link
Collaborator

@panjf2000 panjf2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golint issue for yrand.QuitShuffle is by design, since it acts like filepath.SkipDir, and not a real error.

Then you could add a //nolint: xxx comment upon it to eliminate that warning.

@an63
Copy link
Contributor Author

an63 commented Feb 20, 2020

golint issue for yrand.QuitShuffle is by design, since it acts like filepath.SkipDir, and not a real error.

Then you could add a //nolint: xxx comment upon it to eliminate that warning.

Thanks! I just tried //nolint with this PR but it didn't work. ⚠️

It seems that //nolint is a feature of golangci-lint, and is not supported by golint yet, which is used by Go Report Card. Correct me if I'm wrong. 😢

@an63 an63 requested a review from panjf2000 February 20, 2020 04:00
Copy link
Collaborator

@panjf2000 panjf2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants