Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing userinfo endpoint #709

Merged
merged 6 commits into from
Feb 9, 2023
Merged

missing userinfo endpoint #709

merged 6 commits into from
Feb 9, 2023

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Feb 8, 2023

no userinfo_endpoint -> no userinfo request

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch linked an issue Feb 8, 2023 that may be closed by this pull request
OIDC: userinfo_endpoint is RECOMMENDED, but not REQUIRED #708
Closed
@johakoch johakoch marked this pull request as ready for review February 8, 2023 14:35
@johakoch johakoch requested a review from malud February 8, 2023 14:35
@malud
Copy link
Collaborator

malud commented Feb 8, 2023

nice, thanks for fixing this. Could we rebase to release.1.12 und use this as target?

@johakoch johakoch force-pushed the 708-missing-userinfo_endpoint branch from 5320ce5 to 27d3909 Compare February 8, 2023 16:52
@johakoch johakoch changed the base branch from master to release.1.12 February 8, 2023 16:53
@johakoch johakoch changed the base branch from release.1.12 to master February 8, 2023 17:00
@johakoch johakoch changed the base branch from master to release.1.12 February 8, 2023 17:00
@johakoch johakoch force-pushed the 708-missing-userinfo_endpoint branch from cbbcd29 to 27d3909 Compare February 8, 2023 17:08
@johakoch johakoch added this to the 1.12.1 milestone Feb 8, 2023
@alex-schneider alex-schneider merged commit 53238ca into release.1.12 Feb 9, 2023
@alex-schneider alex-schneider deleted the 708-missing-userinfo_endpoint branch February 9, 2023 15:26
@johakoch johakoch removed this from the 1.12.1 milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

@malud malud Awaiting requested review from malud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OIDC: userinfo_endpoint is RECOMMENDED, but not REQUIRED
3 participants
@johakoch @malud @alex-schneider