fold ElmFormat.Cli{,Test} into ElmFormat.Integration #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Not sure we want to keep the golden test call out to |
|
For #302 again! |
|
This also relates to #72 |
avh4
reviewed
Jan 31, 2018
tests/Integration/CliTest.hs
Outdated
| , world | ||
| |> run "elm-format-xxx" [] | ||
| |> TestWorld.goldenStdout "usage instructions" | ||
| "tests/Integration/data/usage.stdout" |
There was a problem hiding this comment.
I think you forgot to check this file in, or else forgot to change this path when you moved the file?
|
Looks like there's one mistake here (see comment above). Otherwise, this looks great! |
|
Thanks for catching that! Indeed, I was moving files around later and tests were passing due to an untracked copy. Pushed a fix. Should I amend it into the buggy commit? |
|
But Travis passed anyway? |
|
No need to amend. Travis passed originally because apparently the behavior of golden is to create the file (and not error) if the file doesn't exist. |
|
Thanks! |
kutyel
pushed a commit
to kutyel/elm-format
that referenced
this pull request
Apr 26, 2022
fold ElmFormat.Cli{,Test} into ElmFormat.Integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the two test cases that require
ElmFormat.Climore-or-less faithfully intoIntegration, which runs against the properElmFormat.mainimplementation. With minimal extensions toTestWorld. To deal with thoseElmFormat.Clicompile warnings. Joint work with @alicebob.