Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dockerfile to build ui #3

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Fixed dockerfile to build ui #3

merged 1 commit into from
Feb 6, 2024

Conversation

CyrilDesch
Copy link

  • NPM install and frontend build need to be present before the go build because the executor contain the frontend
  • Clarify Dockerfile

@aviadhahami
Copy link
Owner

@CyrilDesch - heya and thx! :)
Are you sure about this? for when I tested it locally I had no problems when building like this...

@CyrilDesch
Copy link
Author

I tried on Mac and Linux and I have this problem. Maybe your config on devcontainer solve the problem.

I base my opinion on the fact that there is no UI folder in the downloadable release :
https://github.com/nfx/slrp/releases/tag/v0.3.0

So it seems logical to me that it's inside the "build".

@aviadhahami
Copy link
Owner

its basically the same, im fine with it

@aviadhahami aviadhahami merged commit 020dddf into aviadhahami:main Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants