Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements #17

Merged
merged 22 commits into from
May 13, 2021
Merged

Enhancements #17

merged 22 commits into from
May 13, 2021

Conversation

cbonthala
Copy link
Contributor

Below are some enhancements made for this logger

  1. Add Timer scope
  2. Prefill exception fields
  3. Make logger config required
  4. Evaluate payload only when we actually need it

Resolves reported issues #7 and #13

cbonthala and others added 22 commits May 12, 2021 20:04
@cbonthala
Added notification listener for flow start/stop events and keep pom c…
16a6ae3 
…hanges during rebase
@cbonthala
Added a timer frame component and bumped the version to 1.1.0 and kee…
83ac822 
…p master branch pom changes
@TimGonz-AVIO @cbonthala
Adjusting trace_points
ae42d0e 
Signed-off-by: Tim Gonzales <tgonzales@avioconsulting.com>
@TimGonz-AVIO @cbonthala
Updating mule-modules-parent
7b86412 
Signed-off-by: Tim Gonzales <tgonzales@avioconsulting.com>
@TimGonz-AVIO @cbonthala
Rewording frame to scope
63e8249 
Signed-off-by: Tim Gonzales <tgonzales@avioconsulting.com>
@TimGonz-AVIO @cbonthala
Adding a baseCategory in global config for use in LoggingPipelineNoti…
0796a15 
…ficationListener

Signed-off-by: Tim Gonzales <tgonzales@avioconsulting.com>
@TimGonz-AVIO @cbonthala
Changing parameters to camelCase
a991df0 
Signed-off-by: Tim Gonzales <tgonzales@avioconsulting.com>
@TimGonz-AVIO @cbonthala
Renaming logging notification class
77ae237 
Signed-off-by: Tim Gonzales <tgonzales@avioconsulting.com>
@TimGonz-AVIO @cbonthala
Changed base_category back to snake case, added README details
b871bc7 
Signed-off-by: Tim Gonzales <tgonzales@avioconsulting.com>
@TimGonz-AVIO @cbonthala
Updated package, autoretrieve properties, extracted utilities
25ea6fc 
Signed-off-by: Tim Gonzales <tgonzales@avioconsulting.com>
@TimGonz-AVIO @cbonthala
Refactored TimerScope to use global config
39dfa93 
Signed-off-by: Tim Gonzales <tgonzales@avioconsulting.com>
@TimGonz-AVIO @cbonthala
Added more logic to initLogger and added a test to validate
592411a 
Signed-off-by: Tim Gonzales <tgonzales@avioconsulting.com>
@TimGonz-AVIO @cbonthala
Adjusted conditional to check for contain's . vs just at the beginning
59ce929 
Signed-off-by: Tim Gonzales <tgonzales@avioconsulting.com>
@TimGonz-AVIO @cbonthala
Removing incorrect test file, updating correct test
7504817 
Signed-off-by: Tim Gonzales <tgonzales@avioconsulting.com>
@cbonthala
Added moduleConfigurationName parameter to directly retrieve config
24f1344
@cbonthala
Adding explicit repositories
ff71275
@cbonthala
Update log4j core dependency version to address a security vulnerability
4b22634 
Security Vulnerability for log4j-core versions < 2.13.2: Improper validation of certificate with host mismatch in Apache Log4j SMTP appender. This could allow an SMTPS connection to be intercepted by a man-in-the-middle attack which could leak any log messages sent through that appender.
@cbonthala
pre-fill exception fields
a3af74d
@cbonthala
category prefix fix
ac59c61
@cbonthala
make app version field in logger config as required so that the UI di…
964e29c 
…splays an error when the developer forget to attach config to the logger connector
@cbonthala
evaluate payload only when we actually need it
ef410f9
@cbonthala
suggest to use mule predefined correlationId variable
cd7f7e4
This was linked to issues May 13, 2021
Add a timer frame for logging #7
Closed
Make payload lazily evaluated #13
Closed
@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2021 •
edited
Loading

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 34605ce. ± Comparison against base commit 34605ce.

♻️ This comment has been updated with latest results.

@cbonthala cbonthala closed this May 13, 2021
@cbonthala cbonthala reopened this May 13, 2021
@cbonthala cbonthala merged commit 34605ce into master May 13, 2021
@cbonthala cbonthala deleted the develop branch May 13, 2021 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make payload lazily evaluated Add a timer frame for logging
2 participants
@cbonthala @TimGonz-AVIO