Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow compressing and encrypting log payloads #46

Merged
merged 5 commits into from
Dec 5, 2022
Merged

feat: allow compressing and encrypting log payloads #46

merged 5 commits into from
Dec 5, 2022

Conversation

tannersherman
Copy link
Contributor

No description provided.

@tannersherman
Add Compression and encryption support
2d80130 
Initial commit to add compression and encryption support by leveraging the mule modules
backwards comptabile with mule flow using compressor and crypto module to decrypt and decompress
@tannersherman
updated logic to remove zip compression as it is not necessary for mvp
e00c59e
@tannersherman
Testing and documentation
878454c 
Refactored logic for easier testing
added unit testing for operations class
updated README
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022 •
edited
Loading

Unit Test Results

6 tests  +4   6 ✔️ +4   11s ⏱️ ±0s
3 suites +1   0 💤 ±0 
3 files   +1   0 ❌ ±0 

Results for commit 4cb785c. ± Comparison against base commit cd5bb7e.

♻️ This comment has been updated with latest results.

manikmagar
manikmagar requested changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@manikmagar manikmagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments. Also, could we change the branch name to use conventional commit prefixes, eg. feat/payload-compression-encryption?

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
src/main/java/com/avioconsulting/mule/logger/internal/CustomLoggerOperation.java Outdated Show resolved Hide resolved
src/main/java/com/avioconsulting/mule/logger/internal/CustomLoggerOperation.java Show resolved Hide resolved
src/main/java/com/avioconsulting/mule/logger/internal/config/CustomLoggerConfiguration.java Show resolved Hide resolved
@tannersherman
Updates after review
393bca9 
Adjusted language in README
Removed unneeded plugin from pom
Added java docs to new methods in logger operation class
Added initialise() method to validate encryption algorithm and password are used together when one is provided
@tannersherman
Copy link
Contributor Author

@manikmagar
Thanks for the review, updated the project with your changes. I can't change the name of the remote branch without deleting it and creating a new one. For the purposes of visibility, I'm going to leave the name the same for this pull request. I can change the branch name after this has been approved (and closed), then create a new branch with a new pull request. Otherwise I will ensure to use the proper convention next time

manikmagar
manikmagar approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@manikmagar manikmagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manikmagar manikmagar changed the title Feature/tsherman/payoad compression and encryption feat: allow compressing and encrypting log payloads Dec 5, 2022
@adammead adammead merged commit c20126c into master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manikmagar manikmagar manikmagar approved these changes

@adammead adammead adammead approved these changes

@adesjardin adesjardin adesjardin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tannersherman @adesjardin @adammead @manikmagar