Logic to perform deployment to Cloudhub V2 #59

gteixeira1 · 2022-12-16T11:35:02Z

Resolves #46

…t in Exchange

…pp is started in CH v2

…t and DeployerTest updated

github-actions · 2022-12-16T11:37:24Z

Unit Test Results

313 tests +39 313 ✔️ +39 2m 27s ⏱️ + 1m 23s
  37 suites +  6     0 💤 ±  0
  37 files +  6     0 ❌ ±  0

Results for commit 98fc480. ± Comparison against base commit ad74440.

♻️ This comment has been updated with latest results.

manikmagar · 2022-12-19T23:54:35Z

@gteixeira1 @adesjardin CloudHub 2.0 Deployment Model seems to have a lot of overlap with Runtime Fabric Deployment Model. Instead of making this new module as CH 2 specific, should we abstract this model so we could support RTF deployment with any minor extensions to this base mode?

adesjardin · 2023-06-20T18:37:28Z

...m/avioconsulting/mule/deployment/api/models/deployment/RuntimeFabricDeploymentRequest.groovy

 import com.avioconsulting.mule.deployment.api.models.WorkerSpecRequest
 import com.avioconsulting.mule.deployment.internal.models.CloudhubAppProperties
 import groovy.json.JsonOutput
 import groovy.transform.ToString

 @ToString
 class RuntimeFabricDeploymentRequest extends ExchangeAppDeploymentRequest {
+
+    final MAX_SIZE_APPLICATION_NAME = 42


Should this only be on RTF deployments or also CH v1 deployments and standalone?

Should be on CH v1 too. For standalone, the app-limit may depend on the MULE_HOME path due to overall File PATH restrictions from OS. Having it configurable for standalone might help to be consistent in naming strategy.

* docs: Add README documentation about enabledFeatures * docs: Fix documentation * docs: Improved documentation for each flag of enabledFeatures

…es (#64) * docs: Add README documentation about apiSpec section and its attributes * docs: Fix designCenterBranchName attribute name in the examples

…hen do not deploy API manager (#65) * feat: Add method to retrieve existing API in the interface IApiManagerDeployer.groovy * feat: Retrieve API id from API Manager and set into the application when do not deploy API manager * feat: Add examples about API specification and API id retrieval * test: Change unit tests to attend the new implementation of set API id without API manager deploy

…H 2.0 and RTF

* docs: Added sample custom policy configuration * chore: deployment app name refactor * chore: updates to make all tests pass * chore: Use Java 11 on GitHub actions build * chore: Use Java 17 on GitHub actions build * fix: updating test projects to maven 3.5.4 * fix: updating test projects to maven 3.8.2 * fix: updates for java 8 * fix: Optional object needed additional .get() * fix: updated tests to use the new applicationName object * fix: updated tests to use the new applicationName object * chore: Remove unnecessary code --------- Co-authored-by: Kevin King <36522886+kkingavio@users.noreply.github.com> Co-authored-by: Francisco Rodriguez Rojas <fr.rodriguez@pm.me> Co-authored-by: Kevin King <kking@avioconsulting.com> Co-authored-by: Talysson Castro <talyssoncastro@gmail.com>

* Resolve conflicts * feat: Validate if mainRamlFile exists on separated method * feat: Support API manager and Policies deploy when using CH 2.0 and RTF deployment * refactor: Use base class AppDeploymentRequest.groovy and create getUnsupportedFeatures * feat: Return null for RAML files for ExchangeAppDeploymentRequest and derived classes * feat: Move DesignCenter as unsupported to the proper class - ExchangeAppDeploymentRequest * feat: Improve parameter name * docs: Improve examples * docs: Add example of CH 2.0 with API Manager and Policy sync * feat: Encapsulate logic of testing null on RAML files * feat: Add autoDiscoveryId property into deployment properties for RTF and CH 2.0 * Use ApplicationName in tests * Requires appName for RTF and CH 2.0 applications * Fix CloudHub integration test * test: Unit test about validating empty name for RTF and CH 2.0 apps

…ame feature in the specification (#83)

* chore: Remove cloudHubAppPrefix from docs and unit tests

* test: Create suites for integration and unit tests to run separated * build: Add condition to run only unit test when branch is not master

manikmagar · 2024-01-04T05:23:53Z

library/examples/muleDeploy_ch2_sharedspace_full.groovy.groovy

+        applicationName
+        applicationName {


Looks like left a duplicate by mistake.

manikmagar · 2024-01-04T06:44:32Z

...rc/main/java/com/avioconsulting/mule/deployment/api/models/deployment/ApplicationName.groovy

+    }
+
+    private void runGuards(){
+        assert (baseAppName != null && !baseAppName.isBlank() && !baseAppName.contains(" ")) : "you should specify an non-empty baseAppName. It shouldn't contain spaces as well"


Are special characters other than spaces allowed as app name? Eg. some#app*&$name. Current validation accepts that name. Maybe just restricting it to Alphanumeric and Dash is better?

Error message formatting, could be a simple message Application name cannot be empty and cannot contain spaces. If more characters are not allowed then probably we can just say that "Name must be alphanumeric and can include dash."

manikmagar · 2024-01-04T07:16:48Z

library/src/main/resources/evaluate.gdsl.vm

+        #boolParam('usePrefix')
+        #boolParam('useSuffix')
+        #stringParam('prefix')
+        #stringParam('suffix')


Curious to know if we need pairs of properties eg usePrefix and prefix? Can the existence of valid prefix or suffix strings not be used to decide and reduce the configuration elements? Changing this later would mean breaking change, so asking before 2.0 is released.

manikmagar · 2024-01-04T07:37:08Z

maven-plugin/pom.xml

+            <version>${junit.platform.version}</version>
+            <scope>test</scope>


Should we move this dependencyManagement in parent pom? Could be done later too.

… parent POM and use them in children's projects (#88)

* feat: Change valid characters logic in the application name * test: Fix and add unit tests for application name feature * Improve regex to validate application name Co-authored-by: Manik Magar <manik.magar@gmail.com> * feat: Use the new validateName method to validate application name * test: Fix unit tests for the new message about invalid application name --------- Co-authored-by: Manik Magar <manik.magar@gmail.com>

* feat: Remove usePrefix and useSuffix attributes * docs: Remove usePrefix and useSuffix from examples * test: Fix unit tests that use usePrefix and useSuffix properties * test: Fix unit tests that use usePrefix and useSuffix properties * test: Keep unit tests with original behaviour for usePrefix and useSuffix * test: Keep unit tests with original behaviour for usePrefix and useSuffix

* docs: Add documentation for usages of ApplicationName feature * docs: Remove usePrefix and useSuffix from README documentation

Guilherme Teixeira and others added 16 commits November 24, 2022 18:08

Added first version of DSL file for cloudhub v2

18a7219

Added full list of parameters on DSL for cloudhub v2 version

99584e8

Added Cloudhub v2 base request specs

4e88f6a

Added additional settings to cloudhub v2 specification

b9cbf2c

Added cloudhub v2 library classes

5dffe2f

Added new classes for cloudhb v2

b15c5dc

Updated cloudhub v2 classes to reflect required parametes on DSL files

4a80332

Merge branch 'master' into cloudhub2

f70dd0d

Updated MuleDeployContext logic to set the type of deployment

222bc64

Updated classes to perform CH v2 deployment - artifact already presen…

4a26d45

…t in Exchange

Added logic to update api in Cloudhub v2

8977e85

Added CH v2 status to current classes and updated logic to check if a…

bf8d3be

…pp is started in CH v2

Removed duplicated parameter 'target' from CloudhubV2DeploymentReques…

b83c9c1

…t and DeployerTest updated

Removed unused property analyticsAgentEnabled from CH v2 classes

84392bb

Refactored UpdateStrategy class name. Added CloudhubV2Context Test

5adb1bd

Refactore classes names

f3249e8

Guilherme Teixeira added 6 commits December 16, 2022 14:56

Added logic to accept groupId from DSL file

f4f6e5d

Added missing worker spec parameters

f7fcd09

Added tests for CloudHub v2

f41f41b

Added business group to DSL

2794241

Added test to CloudHubV2Deployer

ffe1f94

Removed unused methods

ab4f060

gteixeira1 requested review from manikmagar and adesjardin December 19, 2022 18:55

Guilherme Teixeira added 4 commits December 27, 2022 06:40

Added first version of Runtime Fabric DSL example

ec698ea

Added Runtime Fabric classes

8a41eab

Refactored code to have common methods used by RTF and CH2

125ffe7

Refactored WorkerSpecRequest class name

74119fc

adesjardin reviewed Jun 20, 2023

View reviewed changes

docs: Add README documentation about enabledFeatures (#63)

369fb11

* docs: Add README documentation about enabledFeatures * docs: Fix documentation * docs: Improved documentation for each flag of enabledFeatures

adesjardin previously approved these changes Jun 28, 2023

View reviewed changes

docs: Add README documentation about apiSpec section and its attribut…

1bc8ead

…es (#64) * docs: Add README documentation about apiSpec section and its attributes * docs: Fix designCenterBranchName attribute name in the examples

talyssoncastro dismissed adesjardin’s stale review via 1bc8ead June 28, 2023 16:27

talyssoncastro and others added 12 commits June 28, 2023 13:27

feat: Support API manager and Policies management when deploying to C…

cd326b5

…H 2.0 and RTF

Merge branch 'master' into feat/cloudhub2

d141c51

test: Adding additional integration test cases for Cloudhub v2

84f1827

feat: Masking sensitive values in log messages

b11cc98

docs: Fix the muleDeploy.groovy example files to use the ApplicationN…

d4b5e86

…ame feature in the specification (#83)

chore: Remove cloudHubAppPrefix from docs and unit tests (#84)

cee220f

* chore: Remove cloudHubAppPrefix from docs and unit tests

chore: Change project version to 2.0.0-SNAPSHOT

22212c4

test: Migrate to JUnit 5

ed26090

* test: Create suites for integration and unit tests to run separated * build: Add condition to run only unit test when branch is not master

Merge branch 'master' into feat/cloudhub2

9d1da4c

manikmagar reviewed Jan 4, 2024

View reviewed changes

talyssoncastro and others added 6 commits January 5, 2024 15:02

fix: Remove duplicate ApplicationName specification on examples

379b7b0

chore: Move the JUnit dependencies to dependencyManagement section in…

1ee6ade

… parent POM and use them in children's projects (#88)

test: Add a test case to cover empty baseAppName

f0cd0a2

docs: Add documentation for usages of ApplicationName feature (#89)

722f1a8

* docs: Add documentation for usages of ApplicationName feature * docs: Remove usePrefix and useSuffix from README documentation

adesjardin approved these changes Jan 17, 2024

View reviewed changes

talyssoncastro merged commit eda9e70 into master Jan 17, 2024
5 checks passed

talyssoncastro deleted the feat/cloudhub2 branch January 17, 2024 21:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Logic to perform deployment to Cloudhub V2 #59

Logic to perform deployment to Cloudhub V2 #59

gteixeira1 commented Dec 16, 2022 •

edited by manikmagar

Loading

github-actions bot commented Dec 16, 2022 •

edited

Loading

manikmagar commented Dec 19, 2022

adesjardin Jun 20, 2023

manikmagar Aug 25, 2023

manikmagar Jan 4, 2024 •

edited

Loading

manikmagar Jan 4, 2024

manikmagar Jan 4, 2024 •

edited

Loading

manikmagar Jan 4, 2024 •

edited

Loading

		<version>${junit.platform.version}</version>
		<scope>test</scope>

Logic to perform deployment to Cloudhub V2 #59

Logic to perform deployment to Cloudhub V2 #59

Conversation

gteixeira1 commented Dec 16, 2022 • edited by manikmagar Loading

github-actions bot commented Dec 16, 2022 • edited Loading

Unit Test Results

manikmagar commented Dec 19, 2022

adesjardin Jun 20, 2023

Choose a reason for hiding this comment

manikmagar Aug 25, 2023

Choose a reason for hiding this comment

manikmagar Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

manikmagar Jan 4, 2024

Choose a reason for hiding this comment

manikmagar Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

manikmagar Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

gteixeira1 commented Dec 16, 2022 •

edited by manikmagar

Loading

github-actions bot commented Dec 16, 2022 •

edited

Loading

manikmagar Jan 4, 2024 •

edited

Loading

manikmagar Jan 4, 2024 •

edited

Loading

manikmagar Jan 4, 2024 •

edited

Loading