Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mip 312 #12

Merged
merged 10 commits into from
Jul 7, 2020
Merged

Feature/mip 312 #12

merged 10 commits into from
Jul 7, 2020

Conversation

kkingavio
Copy link
Contributor

LoggerCategoryExistsRule - Specifically checking that a category attribute exists and is not empty
LoggerMessageExistsRule - Specifically checking the message attribute

LoggerAttributesRule - Can pass a list of attributes to require

@kkingavio kkingavio changed the base branch from master to develop July 7, 2020 12:47

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@adesjardin adesjardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. We should also add a test class for MuleComponent as well probably, even it it only tests hasAttributeValue for now. To show the expected behaviors there.

@kkingavio kkingavio requested a review from adesjardin July 7, 2020 20:04
@kkingavio kkingavio merged commit 21f9540 into develop Jul 7, 2020
@kkingavio kkingavio deleted the feature/MIP-312 branch July 7, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants