feat: Added linter rule to check format of properties name in the properties file. #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perties file. Added linter rule - PROPERTIES_NAMING to check format of properties name in the properties file. This rule checks that properties name in the properties file follow a given case format. Also, added comments in the AutoDiscovery, CronExpression and APIKit Version rule.
Added linter rule - PROPERTIES_NAMING to check that properties name in the properties files (.properties and YAML) follow predefined acceptable format such as java property naming conventions (db.username).
Updated PROPERTIES_NAMING rule to support java properties format
|
@dileepkumarv-avio @adesjardin Should we do it as "PROPERTY_NAME_PATTERN" rule that defaults the regex pattern but also allow to change it if needed? |
TimGonz-AVIO
approved these changes
Aug 18, 2023
|
@manikmagar Renaming this rule to PROPERTY_NAME_PATTERN makes sense to me. I will rename the rule to PROPERTY_NAME_PATTERN. Also, i will add optional attribute within the rule to allow different pattern for property name. |
Renamed the linter rule to PROPERTY_NAME_PATTERN, and added support to pass format into the linter rule.
TimGonz-AVIO
approved these changes
Aug 23, 2023
adesjardin
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added linter rule - PROPERTIES_NAMING to check that properties name in the properties files (.properties and YAML) follow predefined acceptable format such as java property naming conventions (db.username).