Feature/mip 399 #16
Merged
Feature/mip 399 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkingavio
requested changes
Jul 9, 2020
|
|
||
| class FlowSubflowNamingRule extends Rule { | ||
|
|
||
| enum CaseFormat { |
There was a problem hiding this comment.
I would pull this logic out into a StringUtil or StringParser(?) I know Adam doesn't like naming classes 'Util'....
We would want to be able to check any string, against a format... so that it can be reused in many rules...
Then we can write some tests that just parse strings, and you wouldn't need so many config files...
|
@kkingavio take a look again, made changes as suggested. |
kkingavio
requested changes
Jul 9, 2020
|
|
||
| private static final String NAMING_APP = 'FlowSubflowNaming' | ||
|
|
||
| private static final String CAMEL_CASE_FILE = 'camelCase.xml' |
There was a problem hiding this comment.
Limit to 1 file that contains a flow for each naming case... and check that the correct flow passes in each of the different naming scenarios.
kkingavio
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow subflow naming convention rule -> camelCase, PascalCase, snake_case, and kebab-base