Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Github Action #72

Merged
merged 6 commits into from
Mar 1, 2021
Merged

Added Github Action #72

merged 6 commits into from
Mar 1, 2021

Conversation

thedevnisarg
Copy link
Contributor

No description provided.

@thedevnisarg thedevnisarg added the enhancement New feature or request label Feb 26, 2021
@github-actions

This comment has been minimized.

Copy link
Contributor

@adesjardin adesjardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small things to correct

.gitignore Outdated
@@ -11,7 +11,7 @@
.mtj.tmp/

# Package Files #
*.jar
# *.jar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't jar files still be excluded from git commits?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added back in.

version.minor=0
version.patch=1
version.prerelease=SNAPSHOT
version.semver=1.0.1-SNAPSHOT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be on 1.0.0-SNAPSHOT right now, there are no previous releases of the linter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@thedevnisarg thedevnisarg requested a review from adesjardin March 1, 2021 16:48
@thedevnisarg thedevnisarg merged commit e1acd70 into master Mar 1, 2021
@thedevnisarg thedevnisarg deleted the feature/github-action branch March 1, 2021 17:50
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2021

Unit Test Results

  44 files  ±0    44 suites  ±0   3s ⏱️ ±0s
207 tests ±0  207 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e1acd70. ± Comparison against base commit e1acd70.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants