Branch list tidy up #322
Merged
Branch list tidy up #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nches will be sorted and the default branch moved to the top of the list.
jp7677
suggested changes
Oct 13, 2023
src/main/kotlin/nl/avisi/structurizr/site/generatr/GenerateSiteCommand.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/nl/avisi/structurizr/site/generatr/GenerateSiteCommand.kt
Outdated
Show resolved
Hide resolved
Added test
|
@jp7677 It feels weird having the branch comparator function sitting outside the class. Probably because I'm just not that used to Kotlin :) |
jp7677
approved these changes
Oct 16, 2023
I guess both, outside the class or as companion object within the class, would be fine as long as writing tests is still easy. I opted for outside since you could say that sorting with that order is a kind-of general thing. I guess linters would suggest to put it into a separate file with the name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorts the list of branches in a multi-branch site and moves the default branch to the top of the list.