fix: broken documentation indexing with correct URLs #615
Conversation
galuszkak
changed the title
There was a problem hiding this comment.
Would you mind adding tests for no container sections, no container decisions, indexes container decisions and indexes container sections, similar like the existing ones for software systems?
While at it, no software system documentation should be named no container sections.
There was a problem hiding this comment.
@jenspav added, please review.
I didn't quite catch the last comment, this is actually testing no software system documentation and has nothing to do with containers, so I'm unsure what you referring there.
There was a problem hiding this comment.
I didn't quite catch the last comment, this is actually testing no software system documentation and has nothing to do with containers, so I'm unsure what you referring there.
Sry, typo on my side, what I meant was: Could you please also rename this function https://github.com/avisi-cloud/structurizr-site-generatr/blob/main/src/test/kotlin/nl/avisi/structurizr/site/generatr/site/model/IndexingTest.kt#L282 to no software system section for consistency with the other tests.
There was a problem hiding this comment.
@jenspav done, please review now.
| ) | ||
| }/sections/${section.order}".asUrlToDirectory(viewModel.url), | ||
| "Documentation", | ||
|
|
There was a problem hiding this comment.
Sorry, missed this one earlier, could you please remove this empty line? Everything else LGTM!
|
Thanks! |
This PR fixes indexing that has been broken by #550 .
Also enables indexing of Container level decisions and documentation. To be fully consistent with new structure.