Make element links in embedded SVGs relative #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those are meant for downloading, having links in them in kind-of useless.
jp7677
force-pushed
the
relative-links-in-diagrams
branch
2 times, most recently
from
f587a42 to
b3fe5bf
Compare
This fixes broken links when the generate site is not hosted as root web site. As a consequence we no longer generate embedded SVG's up-front, but generate them as we need them with links relative to the link of the current page. To preserve generation speed for serve, we try to cache as much as we can.
jp7677
force-pushed
the
relative-links-in-diagrams
branch
from
b3fe5bf to
aefd63b
Compare
This can greatly improve site generation for bigger sites with lots of views.
dirkgroot
reviewed
Nov 15, 2022
src/main/kotlin/nl/avisi/structurizr/site/generatr/site/C4PlantUmlExporterWithElementLinks.kt
Outdated
Show resolved
Hide resolved
Also some renames and argument ordering for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes broken links when the generate site is not hosted as root web site as reported in #85.
As a consequence we no longer generate embedded SVG's up-front, but generate them as we need them with links relative to the link of the current page.