Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bonding cleanup password issue #2280

Merged
merged 1 commit into from
Apr 28, 2022
Merged

bonding cleanup password issue #2280

merged 1 commit into from
Apr 28, 2022

Conversation

PavamanSubramaniyam
Copy link
Contributor

Peer Interfaes link up and mtu 1500 setup code is brought outside the for loop of the code used to make the host interfaces up

Signed-off-by: Pavaman Subramaniyam pavsubra@linux.vnet.ibm.com

@PavamanSubramaniyam
bonding cleanup password issue
eede47d 
Peer Interfaes link up and mtu 1500 setup code is brought outside the for loop of the code used to make the host interfaces up

Signed-off-by: Pavaman Subramaniyam <pavsubra@linux.vnet.ibm.com>
@PavamanSubramaniyam
Copy link
Contributor Author

PavamanSubramaniyam commented Apr 25, 2022 •
edited
Loading

Executed these tests after the changes made in the bonding.py file in the test_cleanup() function on the ShinnerT adapter ports.

[root@ltcden4-lp16 ~]# lspci
0010:01:00.0 Ethernet controller: Broadcom Inc. and subsidiaries NetXtreme II BCM57810 10 Gigabit Ethernet (rev 10)
0010:01:00.1 Ethernet controller: Broadcom Inc. and subsidiaries NetXtreme II BCM57810 10 Gigabit Ethernet (rev 10)
[root@ltcden4-lp16 ~]# ethtool -i eth0
driver: bnx2x
version: 5.14.0-70.9.1.el9_0.ppc64le
firmware-version: bc 7.10.4 phy 1.34
expansion-rom-version:
bus-info: 0010:01:00.0
supports-statistics: yes
supports-test: yes
supports-eeprom-access: yes
supports-register-dump: yes
supports-priv-flags: yes
[root@ltcden4-lp16 ~]# ethtool -i eth1
driver: bnx2x
version: 5.14.0-70.9.1.el9_0.ppc64le
firmware-version: bc 7.10.4 phy 1.34
expansion-rom-version:
bus-info: 0010:01:00.1
supports-statistics: yes
supports-test: yes
supports-eeprom-access: yes
supports-register-dump: yes
supports-priv-flags: yes

[root@ltcden4-lp16 net]# cat bonding.py.data/bonding.yaml
Test: !mux
round-robin:
bonding_mode: "0"
active-backup:
bonding_mode: "1"
balance-xor:
bonding_mode: "2"
broadcast:
bonding_mode: "3"
802.3ad:
bonding_mode: "4"
balance-tlb:
bonding_mode: "5"
balance-alb:
bonding_mode: "6"
bond_interfaces: "eth0 eth1"
host_ips: "17.1.1.21 18.1.1.21"
netmask: "255.255.255.0"
peer_ip: "17.1.1.183"
peer_interfaces: "eth0"
bond_name: "bondtest"
user_name: "root"
peer_bond_needed: False
peer_wait_time: "10"
sleep_time: "5"
mtu: "1500"
[root@ltcden4-lp16 net]# avocado run --test-runner runner bonding.py -m bonding.py.data/bonding.yaml --execution-order tests-per-variant
JOB ID : 582a2d0de6a5c177e92cdf5d61df6cfe4bedc6a9
JOB LOG : /root/avocado-fvt-wrapper/results/job-2022-04-22T07.32-582a2d0/job.log
(01/21) bonding.py:Bonding.test_setup;run-Test-round-robin-23d1: PASS (82.89 s)
(02/21) bonding.py:Bonding.test_run;run-Test-round-robin-23d1: PASS (357.92 s)
(03/21) bonding.py:Bonding.test_cleanup;run-Test-round-robin-23d1: PASS (20.43 s)
(04/21) bonding.py:Bonding.test_setup;run-Test-active-backup-e797: PASS (83.01 s)
(05/21) bonding.py:Bonding.test_run;run-Test-active-backup-e797: PASS (356.08 s)
(06/21) bonding.py:Bonding.test_cleanup;run-Test-active-backup-e797: PASS (20.31 s)
(07/21) bonding.py:Bonding.test_setup;run-Test-balance-xor-6cb2: PASS (83.17 s)
(08/21) bonding.py:Bonding.test_run;run-Test-balance-xor-6cb2: PASS (360.97 s)
(09/21) bonding.py:Bonding.test_cleanup;run-Test-balance-xor-6cb2: PASS (20.43 s)
(10/21) bonding.py:Bonding.test_setup;run-Test-broadcast-6a0b: PASS (83.07 s)
(11/21) bonding.py:Bonding.test_run;run-Test-broadcast-6a0b: PASS (354.90 s)
(12/21) bonding.py:Bonding.test_cleanup;run-Test-broadcast-6a0b: PASS (20.45 s)
(13/21) bonding.py:Bonding.test_setup;run-Test-802.3ad-7e78: PASS (82.88 s)
(14/21) bonding.py:Bonding.test_run;run-Test-802.3ad-7e78: PASS (355.13 s)
(15/21) bonding.py:Bonding.test_cleanup;run-Test-802.3ad-7e78: PASS (20.59 s)
(16/21) bonding.py:Bonding.test_setup;run-Test-balance-tlb-5184: PASS (83.14 s)
(17/21) bonding.py:Bonding.test_run;run-Test-balance-tlb-5184: PASS (356.12 s)
(18/21) bonding.py:Bonding.test_cleanup;run-Test-balance-tlb-5184: PASS (20.19 s)
(19/21) bonding.py:Bonding.test_setup;run-Test-balance-alb-5fe2: PASS (83.01 s)
(20/21) bonding.py:Bonding.test_run;run-Test-balance-alb-5fe2: PASS (360.11 s)
(21/21) bonding.py:Bonding.test_cleanup;run-Test-balance-alb-5fe2: PASS (48.56 s)
RESULTS : PASS 21 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2022-04-22T07.32-582a2d0/results.html
JOB TIME : 3260.29 s

@PavamanSubramaniyam
Copy link
Contributor Author

PavamanSubramaniyam commented Apr 25, 2022 •
edited
Loading

Executed these tests after the changes made in the bonding.py file in the test_cleanup() function on the Haleakala SRIOV Ethernet VF adapter ports.

[root@ ~]# lspci
400a:01:00.0 Ethernet controller: Mellanox Technologies MT28800 Family [ConnectX-5 Ex Virtual Function]
400b:01:00.0 Ethernet controller: Mellanox Technologies MT28800 Family [ConnectX-5 Ex Virtual Function]

[root@ ~]# ethtool -i eth0
driver: mlx5_core
version: 5.0-0
firmware-version: 16.32.1010 (IBM0000000020)
expansion-rom-version:
bus-info: 400a:01:00.0
supports-statistics: yes
supports-test: yes
supports-eeprom-access: no
supports-register-dump: no
supports-priv-flags: yes
[root@ ~]# ethtool -i eth1
driver: mlx5_core
version: 5.0-0
firmware-version: 16.32.1010 (IBM0000000020)
expansion-rom-version:
bus-info: 400b:01:00.0
supports-statistics: yes
supports-test: yes
supports-eeprom-access: no
supports-register-dump: no
supports-priv-flags: yes

[root@ ~]# cat bonding.py.data/bonding.yaml
Test: !mux
round-robin:
bonding_mode: "0"
active-backup:
bonding_mode: "1"
balance-xor:
bonding_mode: "2"
broadcast:
bonding_mode: "3"
802.3ad:
bonding_mode: "4"
balance-tlb:
bonding_mode: "5"
balance-alb:
bonding_mode: "6"
bond_interfaces: "eth0 eth1"
host_ips: "17.1.1.31 18.1.1.31"
netmask: "255.255.0.0"
peer_ip: "17.1.1.140"
peer_interfaces: "eth0 eth1"
peer_public_ip: "x.x.x.x"
bond_name: "bondtest"
user_name: "root"
peer_bond_needed: False
peer_wait_time: "10"
sleep_time: "5"
mtu: "1500"
[root@ ~]# avocado run --test-runner runner bonding.py -m bonding.py.data/bonding.yaml --execution-order tests-per-variant
JOB ID : a98ad12832f9f4fcd578b292b80fd6244dcd79f3
JOB LOG : /root/avocado-fvt-wrapper/results/job-2022-04-20T06.16-a98ad12/job.log
(01/21) bonding.py:Bonding.test_setup;run-Test-round-robin-7d59: PASS (19.94 s)
(02/21) bonding.py:Bonding.test_run;run-Test-round-robin-7d59: PASS (247.87 s)
(03/21) bonding.py:Bonding.test_cleanup;run-Test-round-robin-7d59: PASS (7.23 s)
(04/21) bonding.py:Bonding.test_setup;run-Test-active-backup-7298: PASS (19.96 s)
(05/21) bonding.py:Bonding.test_run;run-Test-active-backup-7298: PASS (247.90 s)
(06/21) bonding.py:Bonding.test_cleanup;run-Test-active-backup-7298: PASS (7.24 s)
(07/21) bonding.py:Bonding.test_setup;run-Test-balance-xor-5082: PASS (20.02 s)
(08/21) bonding.py:Bonding.test_run;run-Test-balance-xor-5082: PASS (247.84 s)
(09/21) bonding.py:Bonding.test_cleanup;run-Test-balance-xor-5082: PASS (7.31 s)
(10/21) bonding.py:Bonding.test_setup;run-Test-broadcast-56ac: PASS (19.97 s)
(11/21) bonding.py:Bonding.test_run;run-Test-broadcast-56ac: PASS (247.77 s)
(12/21) bonding.py:Bonding.test_cleanup;run-Test-broadcast-56ac: PASS (7.11 s)
(13/21) bonding.py:Bonding.test_setup;run-Test-802.3ad-24a4: PASS (20.06 s)
(14/21) bonding.py:Bonding.test_run;run-Test-802.3ad-24a4: PASS (247.96 s)
(15/21) bonding.py:Bonding.test_cleanup;run-Test-802.3ad-24a4: PASS (7.36 s)
(16/21) bonding.py:Bonding.test_setup;run-Test-balance-tlb-a8be: PASS (19.94 s)
(17/21) bonding.py:Bonding.test_run;run-Test-balance-tlb-a8be: PASS (247.87 s)
(18/21) bonding.py:Bonding.test_cleanup;run-Test-balance-tlb-a8be: PASS (7.19 s)
(19/21) bonding.py:Bonding.test_setup;run-Test-balance-alb-a37b: PASS (19.98 s)
(20/21) bonding.py:Bonding.test_run;run-Test-balance-alb-a37b: PASS (247.92 s)
(21/21) bonding.py:Bonding.test_cleanup;run-Test-balance-alb-a37b: PASS (7.26 s)
RESULTS : PASS 21 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2022-04-20T06.16-a98ad12/results.html
JOB TIME : 1926.76 s

@PavamanSubramaniyam
Copy link
Contributor Author

PavamanSubramaniyam commented Apr 25, 2022 •
edited
Loading

Executed these tests after the changes made in the bonding.py file in the test_cleanup() function on the ibmvnic adapter ports.

[root@ltcden11-lp2 ~]# ethtool -i env3
driver: ibmvnic
version: 1.0.1
firmware-version: 001600301004
expansion-rom-version:
bus-info:
supports-statistics: yes
supports-test: no
supports-eeprom-access: no
supports-register-dump: no
supports-priv-flags: yes
[root@ltcden11-lp2 ~]# ethtool -i env4
driver: ibmvnic
version: 1.0.1
firmware-version: 001400301004
expansion-rom-version:
bus-info:
supports-statistics: yes
supports-test: no
supports-eeprom-access: no
supports-register-dump: no
supports-priv-flags: yes

[root@ net]# cat bonding.py.data/bonding_single.yaml
bonding_mode: "0"
bond_interfaces: "env3 env4"
host_ips: "112.10.10.213 113.10.10.213"
netmask: "255.255.255.0"
peer_ip: "112.10.10.219"
peer_interfaces: "env4"
bond_name: "bondtest"
user_name: "root"
peer_bond_needed: False
peer_wait_time: "10"
sleep_time: "5"
mtu: "1500"
[root@ net]# avocado run --test-runner runner bonding.py -m bonding.py.data/bonding_single.yaml --execution-order tests-per-variant
JOB ID : f4828a9afe6841939de6917315b9ded235808fe0
JOB LOG : /home/ioci/avocado-fvt-wrapper/results/job-2022-04-25T00.34-f4828a9/job.log
(1/3) bonding.py:Bonding.test_setup;run-31cf: PASS (22.60 s)
(2/3) bonding.py:Bonding.test_run;run-31cf: PASS (191.12 s)
(3/3) bonding.py:Bonding.test_cleanup;run-31cf: PASS (64.90 s)
RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /home/ioci/avocado-fvt-wrapper/results/job-2022-04-25T00.34-f4828a9/results.html
JOB TIME : 288.40 s

@PraveenPenguin
Copy link
Member

@vaishnavibhat can you please have look on this Request

abdhaleegit
abdhaleegit approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@abdhaleegit abdhaleegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this code fix on my setup and the problem is fixed

[root@ltc-zz1b-lp2 net]# avocado run --test-runner runner bonding.py --mux-yaml bonding.py.data/bonding.yaml --execution-order tests-per-variant
JOB ID     : 43261e7741e29913befcabf21b32eeea2a0e564c
JOB LOG    : /home/ioci/avocado-fvt-wrapper/results/job-2022-04-26T03.07-43261e7/job.log
 (01/21) bonding.py:Bonding.test_setup;run-Test-round-robin-6cf1: PASS (81.11 s)
 (02/21) bonding.py:Bonding.test_run;run-Test-round-robin-6cf1: PASS (789.30 s)
 (03/21) bonding.py:Bonding.test_cleanup;run-Test-round-robin-6cf1: PASS (46.05 s)
 (04/21) bonding.py:Bonding.test_setup;run-Test-active-backup-d198: PASS (81.79 s)
 (05/21) bonding.py:Bonding.test_run;run-Test-active-backup-d198: PASS (790.24 s)
 (06/21) bonding.py:Bonding.test_cleanup;run-Test-active-backup-d198: PASS (60.98 s)
 (07/21) bonding.py:Bonding.test_setup;run-Test-balance-xor-37c7: PASS (81.85 s)
 (08/21) bonding.py:Bonding.test_run;run-Test-balance-xor-37c7: PASS (792.83 s)
 (09/21) bonding.py:Bonding.test_cleanup;run-Test-balance-xor-37c7: PASS (46.17 s)
 (10/21) bonding.py:Bonding.test_setup;run-Test-broadcast-c553: PASS (81.85 s)
 (11/21) bonding.py:Bonding.test_run;run-Test-broadcast-c553: PASS (789.84 s)
 (12/21) bonding.py:Bonding.test_cleanup;run-Test-broadcast-c553: PASS (46.07 s)
 (13/21) bonding.py:Bonding.test_setup;run-Test-802.3ad-177b: PASS (21.75 s)
 (14/21) bonding.py:Bonding.test_run;run-Test-802.3ad-177b: PASS (790.45 s)
 (15/21) bonding.py:Bonding.test_cleanup;run-Test-802.3ad-177b: PASS (58.53 s)
 (16/21) bonding.py:Bonding.test_setup;run-Test-balance-tlb-9fee: PASS (81.84 s)
 (17/21) bonding.py:Bonding.test_run;run-Test-balance-tlb-9fee: PASS (791.61 s)
 (18/21) bonding.py:Bonding.test_cleanup;run-Test-balance-tlb-9fee: PASS (60.72 s)
 (19/21) bonding.py:Bonding.test_setup;run-Test-balance-alb-f1c9: PASS (81.08 s)
 (20/21) bonding.py:Bonding.test_run;run-Test-balance-alb-f1c9: PASS (789.54 s)
 (21/21) bonding.py:Bonding.test_cleanup;run-Test-balance-alb-f1c9: PASS (46.20 s)
RESULTS    : PASS 21 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /home/ioci/avocado-fvt-wrapper/results/job-2022-04-26T03.07-43261e7/results.html
JOB TIME   : 6436.24 s
[root@ltc-zz1b-lp2 net]#

@PraveenPenguin PraveenPenguin merged commit b2a17a8 into avocado-framework-tests:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaishnavibhat vaishnavibhat Awaiting requested review from vaishnavibhat

@abdhaleegit abdhaleegit Awaiting requested review from abdhaleegit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PavamanSubramaniyam @PraveenPenguin @abdhaleegit