Do not resume but verify paused status #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more compatible behavior with the implementation of the inverse method save_to_file() and with it both methods will now only verify paused status before and after they execute. Signed-off-by: Plamen Dimitrov <plamen.dimitrov@intra2net.com>
|
This pull request introduces 1 alert when merging b2a267d into f34a8a1 - view on LGTM.com new alerts:
|
Hmmm, is this issue caused by me? The overriding method assumes argument that I don't think I touched on my side. |
|
@YongxueHong Could you help reviewing this? Thanks! |
|
Is there any chance we can merge this to free #3518 for reviewing/refactoring since it has two approvals already? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more compatible behavior with the implementation of the inverse method save_to_file() and with it both methods will now only verify paused status before and after they execute.
Signed-off-by: Plamen Dimitrov plamen.dimitrov@intra2net.com