Avocado Jobs Keys #6076
Merged
Avocado Jobs Keys #6076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6076 +/- ##
===========================================
+ Coverage 54.32% 68.63% +14.30%
===========================================
Files 202 202
Lines 21892 21910 +18
===========================================
+ Hits 11892 15037 +3145
+ Misses 10000 6873 -3127 ☔ View full report in Codecov by Sentry. |
richtja
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Hi @harvey0100, thank you for investigating this and finding a solution. I have a few small comments, please take a look. Also, I would like to ask you to add tests which will catch the issues from #6067 in the future. Thank you.
harvey0100
force-pushed
the
jobsfix
branch
2 times, most recently
from
f4d195d to
f0d92c0
Compare
Fix: Handle missing job data in 'avocado jobs list' command - Updated 'handle_list_command' to use `job.get()` for safely accessing job data. - If a key is missing, it now defaults to '<unknown>' instead of causing a crash. - Refactored some code due to codeclimate suggestion. Reference: avocado-framework#6067 Signed-off-by: Harvey Lynden <hlynden@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Handle missing job data in 'avocado jobs list' command
job.get()for safely accessing job data.Reference: #6067