Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught Error: Cannot find module '/node_modules/filesize/lib/filesize' #87

Closed
binarykitchen opened this issue Apr 30, 2017 · 5 comments

Comments

@binarykitchen
Copy link

Looks like with the recent version bump v3.5.8 filesize is breaking my local branch for the videomail app.

Does not happen when I revert back to the previous version. Using browserify here to require it. Can you look at this?

@evoyy
Copy link

evoyy commented Apr 30, 2017

I'm also having problems compiling my app with latest filesize.js (v3.5.8). I'm using webpack v1.15.0, node v7.3.0.

WARNING in ./~/filesize/index.js
Critical dependencies:
1:17-155 the request of a dependency is an expression
 @ ./~/filesize/index.js 1:17-155

@avoidwork
Copy link
Owner

Don't use 3.5.8 or webpack? it's a loader script for node.js.

@avoidwork
Copy link
Owner

I'm kinda surprised webpack can't deal with that.

@avoidwork
Copy link
Owner

avoidwork commented Apr 30, 2017

@binarykitchen @evoyy this is a webpack bug. feel free to link them. unit tests pass* when this thing compiles; not my concern. i don't use overly complex toolchains, so I have no skin in this game.

@avoidwork
Copy link
Owner

I'll revert 3.5.8 as 3.5.9 and this'll be considered something that can't be done due to the impact. i'm a little bummed as I was setting this up over 2 years, but shrug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants