Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ES6 build in npm #94

Closed
boris-petrov opened this issue Feb 12, 2018 · 5 comments
Closed

Expose ES6 build in npm #94

boris-petrov opened this issue Feb 12, 2018 · 5 comments

Comments

@boris-petrov
Copy link
Contributor

Thanks for the library! We've been using the ES6 file from the bower distribution, but now have switched to the NPM one where only an ES5 file is available. Perhaps you could also include the ES6 one?

@avoidwork
Copy link
Owner

hi, I tried but it turns out bundlers like webpack assume much and mess with a facade that can load es5 or es6+ code 👎 ... see #87

it has to be more like an extinction, aka 4.0.0 will only be es6+

@boris-petrov
Copy link
Contributor Author

I see. But having an ES6 only build would break, e.g., Ember's build system. When you add something to the "vendor" file there, it doesn't get processed in any way - so when we want to build an ES5 build (for older browsers) we have to use only ES5 files. So that would break this usecase.

Could you not have different directories or something for the different builds?

@avoidwork
Copy link
Owner

Bumping the 'major' implies a breaking change, and taking away a transpile is a breaking change for older RTEs, so I think this is correct.

@avoidwork
Copy link
Owner

Could you not have different directories or something for the different builds?

that's effectively what I had with #87 ... the bundlers do not consider a dynamic load, so what they see at run time is what they spit out.

@avoidwork
Copy link
Owner

3.6.1 includes the es6 version, which you can load via file path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants