Handling empty http2 responses

avoidwork · Nov 24, 2017 · 885ef5b · 885ef5b
1 parent 9d4dd36
commit 885ef5b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/lib/woodland.js b/lib/woodland.js
@@ -154,7 +154,8 @@ class Woodland {
 
 	http2Send (req, res, body, status = 200, headers = null) {
 		if (res.writable) {
-			const output = {":status": status};
+			const output = {":status": status},
+				empty = status === 204 || status === 304;
 
 			each(Object.keys(res._headers).filter(i => invalidHttp2Headers.test(i) === false), i => {
 				output[i] = res._headers[i];
@@ -170,9 +171,9 @@ class Woodland {
 
 			res.statusCode = status;
 
-			if (req.file === void 0) {
+			if (req.file === void 0 || empty) {
 				res.respond(output);
-				res.end(body);
+				res.end(empty === false ? body : void 0);
 			} else {
 				res.respondWithFile(req.file.path, output);
 			}

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "woodland",
-  "version": "4.0.3",
+  "version": "4.0.4",
   "description": "Lightweight HTTP/HTTPS/HTTP2 router with automatic `Allow` & `CORS` headers",
   "main": "index.js",
   "scripts": {