-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pgm->page_erase() function when unable to erase page #1376
Conversation
Just wondering how to test this. I have the STK500V2 based programmer. Supposedly #1266 has already silent the warnings. |
I figured out a way to test this PR.
|
Wiring bootloader testing results: using the MegaCore STK500v2 bootloader. There seems to be an issue but not because of this PR. I will need to check again.
|
@mcuee: well done for testing this. You can also see the difference to git main in the terminal: The jtag2, jtagmkII and stk500v2 programmer variants should not offer the |
I think this PR is safe to merge now. I will check the Wiring bootloader issue later. In any case, I think wiring bootloader is not popular (only used by Arduino Mega2560 board) and the Arduino bootloader FW is not that good (very old optiboot version and also old STK500v2 bootloader with EEPROM bug not fixed). |
Fixes #1267
AVRDUDE treats
pgm->page_erase()
as an optional function that should only be set if the programmer/part actually can erase pages. jtagmkII, jtag3 and stk500v2 programmers offer page_erase() functions that, in some circumstances, cannot erase pages. This PR attempts to correct this behaviour.