Always print error if part and programmer doesn't have a common programming interface #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1110,10 +1110,11 @@ int main(int argc, char * argv []) | |||
| exit(1); | |||
| } | |||
|
|
|||
| if(!ovsigck && partdesc && (p = locate_part(part_list, partdesc)) && !(p->prog_modes & pgm->prog_modes)) { | |||
| if(partdesc && (p = locate_part(part_list, partdesc)) && !(p->prog_modes & pgm->prog_modes)) { | |||
There was a problem hiding this comment.
Should we print use -F to override this check when -F was specified?
|
I'd suggest something like diff --git a/src/main.c b/src/main.c
index 2d0b3fa6..19b41413 100644
--- a/src/main.c
+++ b/src/main.c
@@ -1110,10 +1110,12 @@ int main(int argc, char * argv [])
exit(1);
}
- if(!ovsigck && partdesc && (p = locate_part(part_list, partdesc)) && !(p->prog_modes & pgm->prog_modes)) {
- pmsg_error("programmer %s cannot program part %s as they\n", pgmid, p->desc);
- imsg_error("lack a common programming mode; use -F to override this check\n");
- exit(1);
+ if(partdesc && (p = locate_part(part_list, partdesc)) && !(p->prog_modes & pgm->prog_modes)) {
+ pmsg_error("-c %s cannot program %s for lack of a common programming mode\n", pgmid, p->desc);
+ if(!ovsigck) {
+ imsg_error("use -F to override this check\n");
+ exit(1);
+ }
}
if (pgm->initpgm) { |
This is from @mariusgreuel in Issue avrdudes#1249. avrdudes#1249 > The WIN32 time-out is specified as ReadTotalTimeoutConstant + buflen * ReadTotalTimeoutMultiplier, which makes it potentially much longer than the Posix one (i.e. at least double). ReadIntervalTimeout is also set to timeout, which essentially renders the interval timeout ineffective, so IMHO, we should explicitly disable that feature.
…amming interface even though the user uses -F. It won't exit though.
MCUdude
force-pushed
the
incompatible-warning
branch
from
c99770a
to
9fdd3de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1561 for details. OP used
-Fand didn't get a warning that the part and programmer doesn't share a common programming interface.