Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print warning when avrdude and avrdude.conf versions doesn't match #1564

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

MCUdude
Copy link
Collaborator

@MCUdude MCUdude commented Nov 9, 2023

With this PR Avrdude will print a warning if the avrdude.conf file version doesn't match the avrdude executable version.

$ cat avrdude.conf | grep avrdude_conf_version
avrdude_conf_version = "7.1";

$ ./avrdude -cdryrun -patmega328p -PUSB 
avrdude warning: System wide configuration file version (7.1)
        does not match Avrdude build version (7.2-20230720)
avrdude: AVR device initialized and ready to accept instructions
avrdude: device signature = 0x1e950f (probably m328p)

avrdude done.  Thank you.

Resolves issue #1562

@MCUdude MCUdude added the enhancement New feature or request label Nov 9, 2023
@MCUdude MCUdude linked an issue Nov 9, 2023 that may be closed by this pull request
@mcuee
Copy link
Collaborator

mcuee commented Nov 11, 2023

Looks fine to me.

@stefanrueger
Copy link
Collaborator

I'd rather warn always if the version numbers do not coincide. Technically, AVRDUDE should be able to cope with older configuration files, but in practice you might expect malfunctions. So, I suggest to test str_eq() rather than str_starts().

@MCUdude
Copy link
Collaborator Author

MCUdude commented Nov 11, 2023

I'd rather warn always if the version numbers do not coincide.

Sure! I've replaced str_starts with str_eq now

@stefanrueger stefanrueger merged commit ce59853 into avrdudes:main Nov 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print warning when avrdude and avrdude.conf versions doesn't match
3 participants