Improve signature check for UPDI parts #1840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1813.
Microchip decided to put the
signature
area for UPDI at two different memory offsets, so you now need to know which part you have in order to be able to read thesignature
. This PR checks all different known offsets if an attempt to read a UPDI-part signature draws a blank. It's not fool-proof as, conceivably, if there was a valid signature at the wrong location that byte sequence would mistakenly be understood as the signature of the part.Without this PR:
With this PR:
The code graciously assumes Microchip won't create more than ten different regions for signatures within their UPDI series.