Add checks for zombie sourcecode problems #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndim
force-pushed
the
guard-against-zombie-problems
branch
7 times, most recently
from
3384a81
to
0dcfde8
Compare
This adds checks for zombie sourcecode problems, i.e. problems
we have tried to eliminate but which might be or have been
resurrected.
The example check is for the problematic
#include "ac_cfg.h"
with double quotes instead of <> which were identified as a
problem in avrdudes#1706
and then fixed.
ndim
force-pushed
the
guard-against-zombie-problems
branch
from
1116a0c
to
5176d7b
Compare
|
Great catch. We probably overlooked the |
|
I think this is good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds checks for zombie sourcecode problems, i.e. problems we have tried to eliminate but which might be or have been resurrected.
The example check is for the problematic
with double quotes instead of <> which were identified as a problem in #1706 and then fixed.