Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'windows' folder with giveio.sys driver #769

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

mariusgreuel
Copy link
Contributor

I really need to do this, the giveio.sys driver is of no use any more.

@dl8dtl
Copy link
Contributor

dl8dtl commented Dec 20, 2021

I don't understand the changes to avrdude.texi.
Everything else is fine by me.

@mariusgreuel
Copy link
Contributor Author

mariusgreuel commented Dec 20, 2021

I don't understand the changes to avrdude.texi.

Anything specific? Or do you want to keep the documentation?

@dl8dtl
Copy link
Contributor

dl8dtl commented Dec 20, 2021

I don't understand the changes to avrdude.texi.

Anything specific? Or do you want to keep the documentation?

I was a bit confused about what changed.

Now, upon re-reading it, most is probably fine, but I wouldn't drop those "Credits". Even though their work is going to be removed, at some point in time, these people contributed something that was useful to the project.

@mariusgreuel
Copy link
Contributor Author

but I wouldn't drop those "Credits"

Right. As the entire section on giveio.sys is removed, perhaps AUTHORS is a good place?

@dl8dtl
Copy link
Contributor

dl8dtl commented Dec 21, 2021

but I wouldn't drop those "Credits"

Right. As the entire section on giveio.sys is removed, perhaps AUTHORS is a good place?

Seems reasonable to me. We could add a section like "Contributors to code no longer present" or such.

@dl8dtl dl8dtl merged commit cef773d into avrdudes:main Dec 21, 2021
@mariusgreuel mariusgreuel deleted the pr-windows-cleanup branch December 25, 2021 11:17
@mcuee mcuee added the bug Something isn't working label Jun 20, 2022
@mcuee mcuee mentioned this pull request Jun 27, 2023
@mcuee mcuee mentioned this pull request Aug 8, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants