Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document release workflow #143

Closed
thake opened this issue Jun 2, 2023 · 4 comments
Closed

Document release workflow #143

thake opened this issue Jun 2, 2023 · 4 comments

Comments

@thake
Copy link
Member

thake commented Jun 2, 2023

The release workflow is currently not documented. It should result in a CONTRIBUTING.md.

@Chuckame
Copy link
Contributor

Can you quickly sumup the current procedure? Or by default, I would say: f

  • when pr merged, make a release (tag + github release)
  • when multi pr needed to have a complete feature, then merge into a separate branch, and when all Il merge in this branch, then merge it in main branch

For versioning, let's focus on the library API (public methods dedicated to users) :

  • patch increment for non-breaking, non-new features, fixes of unexpected behaviors or dependency update that don't change the current behavior (e.g. For changing something inside method body, while not changing methods params, params names, methods names, class names, package names)
  • minor increment for new features (not changing current behaviors except when the behavior change is directly linked to a new param, adding method param with a default value that should replicate the same behavior as before, adding property/method/class)
  • major increment for removing/renaming stuff and dependency update that change the current behavior

What do you think?

@Chuckame
Copy link
Contributor

Please also indicate how you are publishing a new version (or it's automatic when release or tag created?)

@Chuckame
Copy link
Contributor

Hey @thake can you show me how to release?

@Chuckame
Copy link
Contributor

Chuckame commented Jul 6, 2023

Found it, just create the release, then execute release workflow inside github actions tab onto the created tag during release

@Chuckame Chuckame closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants