-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Set default to null when the field type is nullable (activable by the configuration) #140
Conversation
90b4cbb
to
b2d47f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR a really useful addition. It will certainly be merged before primitive types.
src/main/kotlin/com/github/avrokotlin/avro4k/schema/ClassSchemaFor.kt
Outdated
Show resolved
Hide resolved
@Chuckame, do you want to join me in maintaining this repo? |
@thake yes, why not!! |
Good idea, did you worked on it since the last commit to your primitives in root branch? |
No, not yet. If you want, you can give it a try. |
Yes I begun something similar to Json, proto, and other native serializers. I would like to lighten the Avro class, make some extensions and make it more configurable (starting with this pr) |
By the way, how do you want me to make releases? That way we add a CONTRIBUTING.md 😁 |
I've opened up an issue #143 for that. Maybe we'll have to change something on the release workflow. |
That sounds really awesome :) Do you want to talk me through before? That way I can give you some input and work out a solution together. You can find my contact details on my github profile, I think we should discuss this "face to face". |
b2d47f0
to
33e9b04
Compare
33e9b04
to
044ccc2
Compare
@thake I also added a little comment on the config field inside the codebase. Ok to merge this and release it ? |
Quick PR that have no impact on the existing features. I hope you will release it before the work of primitives in root 🙏