Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Assume kotlin.Pair as a normal data class instead of an union #174

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

Chuckame
Copy link
Contributor

@Chuckame Chuckame commented Jan 21, 2024

Closes #166

Breaking changes

kotlin.Pair is now a record instead of an union.
It's at the same time a breaking change and a bug fix, as previously we were not able of serializing kotlin Pairs because it was an union instead of a record...

@Chuckame Chuckame requested a review from thake January 22, 2024 13:04
@Chuckame Chuckame added this to the Version 2 milestone Jan 22, 2024
@Chuckame Chuckame mentioned this pull request Jan 22, 2024
14 tasks
@Chuckame Chuckame changed the base branch from main to main-v2 January 27, 2024 15:32
@Chuckame Chuckame merged commit 79a132e into avro-kotlin:main-v2 Jan 27, 2024
1 check passed
@Chuckame Chuckame deleted the fix/kotlin-pair branch January 27, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotlin Pair<A, B> schema is generated as Union<A, B> instead of record
1 participant