Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable checks and argument splitting #8

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Fix variable checks and argument splitting #8

merged 2 commits into from
Jul 27, 2020

Conversation

Flamefire
Copy link
Contributor

Q A
Bug fix? Yes
New feature? No

Description

This removes superflous checks of the form [ ! -z $INPUT_RULES ] : ! -z is -n which is != "" and that is already checked

This allows to pass multiple values in e.g ignore where I used "external --ignore data" as a workaround for #7

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made changes in CHANGELOG.md file

@tarampampam tarampampam merged commit c0b1b25 into avto-dev:master Jul 27, 2020
@tarampampam
Copy link
Contributor

👍 Great thanks for your contribution!

@Flamefire Flamefire deleted the multi_args branch July 27, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarampampam tarampampam tarampampam approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Flamefire @tarampampam