Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appstore): Expose the TokenIssueAt and TokenExpireAt for appstore server api to prevent 401 when default server time is abnormal #278

Merged
merged 1 commit into from
May 16, 2024

Conversation

richzw
Copy link
Collaborator

@richzw richzw commented May 16, 2024

Try to fix #277

… server api to prevent 401 when default server time is abnormal
@richzw richzw requested a review from takecy May 16, 2024 06:06
Copy link
Member

@takecy takecy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick response.
LGTM 👍

@takecy takecy merged commit 947c9eb into awa:master May 16, 2024
2 checks passed
@ganlvtech
Copy link

Sorry, I think this pull request does not fix the issue.

golang-jwt provides a TimeFunc instead of a exact IssuedAt ExpiredAt int value.

https://pkg.go.dev/github.com/golang-jwt/jwt/v5#WithTimeFunc

Maybe we need IssuedAtFunc and ExpiredAtFunc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

appstore api: return status code 401
3 participants