fix(appstore): Use consistent timestamp for issued_at and expired_at #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Store the result of time.Now() in a variable and use it for calculating both issued_at and expired_at - This ensures that issued_at and expired_at are calculated based on the same timestamp
abby-knitta
force-pushed
the
fix/consistent-timestamp-for-issued-at-and-expired-at
branch
from
d479cbf
to
78d0163
Compare
abby-knitta
changed the title
takecy
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: https://developer.apple.com/documentation/appstoreserverapi/generating_json_web_tokens_for_api_requests
In the existing code, time.Now() is called twice separately for issued_at and expired_at. This introduces the possibility of a time gap between these two calls. As a result, the difference between expired_at and issued_at might exceed 60 minutes.
By calling time.Now() only once and storing its value in a variable, we ensure that both issued_at and expired_at refer to the exact same point in time, thus maintaining the expected 60-minute difference between them.