Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IEmbeddingGenerator (Microsoft.Extensions.AI) #124

Closed
aaronpowell opened this issue Oct 29, 2024 · 3 comments
Closed

Implement IEmbeddingGenerator (Microsoft.Extensions.AI) #124

aaronpowell opened this issue Oct 29, 2024 · 3 comments

Comments

@aaronpowell
Copy link

With #112 support for the IChatClient came to be, but there's a companion, IEmbeddingGenerator, which is used for getting embeddings.

It'd be beneficial for that to be supported too for full feature parity with Microsoft.Extensions.AI.
@awaescher
Copy link
Owner

Oh wow, I missed that one. On it.

awaescher added a commit that referenced this issue Oct 29, 2024
@awaescher
Implement IEmbeddingGenerator
bea4592 
Fixes #124
@awaescher
Copy link
Owner

Guess that should be it

@aaronpowell
Copy link
Author

Damn, that was quick!

I'll get that into the next version of the Aspire OllamaSharp integration too 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronpowell @awaescher