Make server process killable #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35163c3 introduced a new use of `mask` which makes the server process uninterruptible while waiting for a new incoming request. This change fixes that by surrounding the logic that waits for a new request with `unmask`. This new `unmask` should still respect the finalization guarantees of the surrounding masked code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
35163c3
introduced a new use of
maskwhich makes the server process uninterruptiblewhile waiting for a new incoming request. This change fixes that by
surrounding the logic that waits for a new request with
unmask. Thisnew
unmaskshould still respect the finalization guarantees of thesurrounding masked code.