Expose ClientCall in ClientReaderHandler and ClientRWHandler #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to cancel the call from within the callback using `clientCallCancel`.
|
@cocreature: Thank you! Just FYI, we may refactor The reason I mention it is that at some point the type of data RequestStatus = Cancel | Continue
ReaderRequest
:: MetadataMap -> TimeoutSeconds -> (response -> IO RequestStatus) -> ReaderRequest... and I wanted to let you know so that such a change doesn't take you by surprise later on. We'll cc: you on those pull requests so that you can review them. |
|
@Gabriel439 Thanks for the heads-up! Sounds like a very reasonable change. |
RichardWarfield
pushed a commit
to litxio/gRPC-haskell
that referenced
this pull request
Apr 25, 2023
RichardWarfield
pushed a commit
to litxio/gRPC-haskell
that referenced
this pull request
Apr 25, 2023
These were the changes I had to made for Hackage to accept the package upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to cancel the call from within the callback using
clientCallCancel.