Add arm64 binary #127
Merged
Add arm64 binary #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib.sh
Outdated
| @@ -103,7 +103,7 @@ function get_normalized_package_list { | |||
| | sed 's/[,\]/ /g; s/\s\+/ /g; s/^\s\+//g; s/\s\+$//g' \ | |||
| | sort -t' ') | |||
| local script_dir="$(dirname -- "$(realpath -- "${0}")")" | |||
| ${script_dir}/apt_query normalized-list ${packages} | |||
| ${script_dir}/apt_query normalized-list ${packages} || ${script_dir}/apt_query-arm64 normalized-list ${packages} | |||
There was a problem hiding this comment.
I think we need sth like this:
# Determine the architecture
local architecture=$(dpkg --print-architecture)
# Use apt_query_arm64 for arm architecture
if [ "${architecture}" == "arm64" ]; then
${script_dir}/apt_query_arm64 normalized-list ${packages}
else
${script_dir}/apt_query normalized-list ${packages}
fi
|
Done. Note that I used a dash instead of an underscore to separate |
thanks a bunch mate 🚀 |
awalsh128
approved these changes
Mar 1, 2024
|
@awalsh128 The full yaml is a bit lengthy: https://github.com/JabRef/jabref/blob/main/.github/workflows/deployment-jdk-ea.yml The core is to sign up at BuildJet to use their arm runners: https://buildjet.com/for-github-actions |
Closed
|
Created #128 to track this and the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126 with a "quick hack" by adding an arm64 binary - and falling back to it when x86 does not work.
I created the binary using the following command: