Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeomUtil and RessourceLimits #509

Closed
80prozent opened this issue Apr 13, 2013 · 3 comments
Closed

GeomUtil and RessourceLimits #509

80prozent opened this issue Apr 13, 2013 · 3 comments
Assignees

Comments

@80prozent
Copy link
Contributor

I fixed some bugs in the Tools/commands by changing the Ressource-Limit-constants in "tools/utils/GeomUtils.as".

As it is right now, it is working for all tools i tested, but i made a lot of tests and think we could set the ressource-Limits higher if we use different LIMIT-constants for verticles and indicies.

Right now the LIMIT for indicies is 3*0xffff (=196605), but the indexBuffer can have a length of 983038 before throwing a error.

The correct LIMIT for the verticle-count seams to be 0xffff (65505).

By using this new LIMITS, tools like mirror or explode, will split into fewer subGeometrys as before.

I thought using fewer Subgeometrys would be a good thing, but the fewer (bigger) subgeometrys are consuming more memory than a lot more (but smaller) subGeometrys.

See this Pic:
limit_ressourcest

I am not shure if i should add this changed LIMIT-values to my commit #503

Any suggestions ?

@80prozent
Copy link
Contributor Author

As you can see in the pic i put in #496, with the new ressource-limits, we can create ca 4 times as much triangles that have SubSurfaceScattering applied, than with the old limits (before the "Ressource-Limit-reached-Error" is thrown).

@ghost ghost assigned DerSchmale Apr 20, 2013
@ghost ghost assigned Fabrice3D Apr 30, 2013
@DerSchmale
Copy link
Member

Fabrice, can you take a look and increase the limit if it's okay?

@Fabrice3D
Copy link
Member

Increased. So far tested, couldn't get a crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants