Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to split this into several requests, but GitHub added commits made after request here too, and I'm not that great git user, so here we go:
fix unpaired mouse over/mouse out events
This one is for situation when we send MouseOver event, then updateCollider fires and changes _previousCollidingObject, so we never actually get MouseOut event for that object, but we do get MouseOut for some other object which did not receive MouseOver yet.
fix ObjectContainer3D bounds calculation
Max* functions actually return Max for largest object in container, not container as a whole (which is probably not what was intended). This version accounts at least for child transition (works well for me)
3)added removeChildAt function
For me this function seems pretty useful for simple usage scenario such as "remove all children". Without such function it requires function chaining: removeChild(getChildAt(index)), which is additionally slower because of unneeded call to indexOf()
OBJParser: do not create zero-length geometries
Got that one on OBJ models that our artists created, so that was not intentionally malformed input
check for zero-length data in CompactSubGeometry
To help detect situations as with OBJParser, as it throws exception later anyway.
normalize normals and tangents after transform
Pretty much self-explaining - normals must be normalized