Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WikiDocs #456

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Add WikiDocs #456

merged 4 commits into from
Jan 9, 2024

Conversation

bverkron
Copy link
Contributor

@bverkron bverkron commented Dec 29, 2023

Add awesome wikidocs project

Thanks for taking the time to suggest an addition to awesome-selfhosted!

To ensure your Pull Request is dealt with swiftly, please check the following (check the boxes [x]):

  • Submit one item per pull request. This eases reviewing and speeds up inclusion.
  • You have searched the repository for any relevant issues or PRs, including closed ones.
  • Any software you are adding is not already listed at any of awesome-sysadmin, staticgen.com, staticsitegenerators.net, dbdb.io.
  • The file you are adding is formatted as described in addition.md.
  • Demo links should only be used for interactive demos, i.e. not video demonstrations.
  • Comments and unused optional fields have been removed.
  • The file you are adding uses kebab-case file naming, for example my-awesome-software.yml.
  • Values for platform are the main server-side requirements for the software. Don't include frameworks or specific dialects.
  • Any software project you are adding to the list is actively maintained.
  • Any software project you are adding was first released more than 4 months ago.
  • Any software project you are adding has working installation instructions.
  • If you are adding software forked from another active project, please provide/link to a clear list of differences between both.
  • You understand that your Pull Request will be merged ~1 week after approval, to allow for further comments if needed.

@nodiscc nodiscc added addition Adding new software to the list reviewers wanted Awaiting reviews labels Dec 29, 2023
@bverkron
Copy link
Contributor Author

Looks like the check failed due to this which is unrelated to my changes?

ERROR:awesome_lint.py: tine - Community Edition: the project is archived

@nodiscc
Copy link
Member

nodiscc commented Dec 29, 2023

Hi

Looks like the check failed due to this which is unrelated to my changes?

correct, your addition passes all automated checks, this failure is unrelated. However,

Any software project you are adding was first released more than 4 months ago.

The first release is from 15 hours ago - we must wait until 29 April 2024 before this can be submitted.

@nodiscc nodiscc closed this Dec 29, 2023
@nodiscc nodiscc added needs to mature Project is younger than 4 months and removed reviewers wanted Awaiting reviews labels Dec 29, 2023
@bverkron
Copy link
Contributor Author

bverkron commented Dec 29, 2023

Ah I did not realize that the line item is meant to be very explicit about it being a Release in GitHub terms. The developer has been making releases since June 14th (over 6 months ago) but they were not added as an actual Release in Github but rather tags.

https://github.com/Zavy86/WikiDocs/releases/tag/1.0.0

Are there exceptions in cases like this @nodiscc?

@nodiscc
Copy link
Member

nodiscc commented Dec 30, 2023

https://github.com/Zavy86/WikiDocs/tags

Tags should be fine.

@nodiscc nodiscc reopened this Dec 30, 2023
@nodiscc nodiscc added reviewers wanted Awaiting reviews and removed needs to mature Project is younger than 4 months labels Dec 30, 2023
Copy link
Collaborator

@kokomo123 kokomo123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing as tags should be fine, LGTM. 💯

Copy link
Collaborator

@Ki-er Ki-er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple changes

software/wikidocs.yml Outdated Show resolved Hide resolved
software/wikidocs.yml Outdated Show resolved Hide resolved
@nodiscc nodiscc removed the reviewers wanted Awaiting reviews label Jan 3, 2024
@nodiscc nodiscc merged commit 2290b71 into awesome-selfhosted:master Jan 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition Adding new software to the list
Development

Successfully merging this pull request may close these issues.

4 participants