LibWeb: Treat non-finite containing block width as zero for percentages

awesomekling · Jul 1, 2023 · 80ff6a6 · 80ff6a6
1 parent c0a5787
commit 80ff6a6
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/...xpected/block-and-inline/percentage-min-width-with-max-content-containing-block-width.txt b/...xpected/block-and-inline/percentage-min-width-with-max-content-containing-block-width.txt
@@ -0,0 +1,8 @@
+Viewport <#document> at (0,0) content-size 800x600 children: not-inline
+  BlockContainer <html> at (0,0) content-size 800x33.46875 [BFC] children: not-inline
+    BlockContainer <body> at (8,8) content-size 200x17.46875 children: not-inline
+      BlockContainer <div> at (8,8) content-size 200x17.46875 children: inline
+        line 0 width: 36.84375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
+          frag 0 from TextNode start: 0, length: 5, rect: [8,8 36.84375x17.46875]
+            "hello"
+        TextNode <#text>
diff --git a/.../input/block-and-inline/percentage-min-width-with-max-content-containing-block-width.html b/.../input/block-and-inline/percentage-min-width-with-max-content-containing-block-width.html
@@ -0,0 +1,9 @@
+<!doctype html><style>
+body {
+    width: max-content;
+}
+div {
+    width: 200px;
+    min-width: 100%;
+}
+</style><body><div>hello
diff --git a/Userland/Libraries/LibWeb/Layout/FormattingContext.cpp b/Userland/Libraries/LibWeb/Layout/FormattingContext.cpp
@@ -1372,7 +1372,7 @@ CSSPixels FormattingContext::calculate_max_content_height(Layout::Box const& box
 
 CSS::Length FormattingContext::calculate_inner_width(Layout::Box const& box, AvailableSize const& available_width, CSS::Size const& width) const
 {
-    auto width_of_containing_block = available_width.to_px();
+    auto width_of_containing_block = available_width.to_px_or_zero();
     auto width_of_containing_block_as_length_for_resolve = CSS::Length::make_px(width_of_containing_block);
     if (width.is_auto()) {
         return width.resolved(box, width_of_containing_block_as_length_for_resolve);